New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCHP diagnostics for GCHPctmEnv and FV3 gridded components #2199
Add GCHP diagnostics for GCHPctmEnv and FV3 gridded components #2199
Conversation
3f27f01
to
328a02a
Compare
94948da
to
4b8a1af
Compare
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
4b8a1af
to
cb77850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lizziel: Looks good but we should also add the new collections to the HISTORY.rc.carbon
template file as well.
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Done! |
I also turned on the collections by default for transport tracer simulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizziel! Approved and I'll start bringing into the no-diff branch.
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #159752f GEOS-Chem submod update: Merge PR #2224 (Fix units of State_Met%PHIS)
GEOS-Chem #ff6db31a6 Merge PR #2199 (Add GCHP diags for GCHPctmEnv and FV3 grid comps)
HEMCO #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 25453401
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% All GEOS-Chem Classic integration tests are zero-diff w/r/t 14.3.0, except for
Also note: geos-chem PR #2224 has now changed the units of State_Met%PHIS, so these show up as differences in the StateMet collection. All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #5ebded8 Merge PR #395 (Expand GCHP advection diagnostics)
GEOS-Chem #ff6db31a6 Merge PR #2199 (Add GCHP diags for GCHPctmEnv and FV3 grid comps)
HEMCO #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)
Number of execution tests: 6
Submitted as SLURM job: 25454095
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% All GCHP integration tests were zero-diff w/r/t 14.3.0, Also note: geos-chem PR #2224 has now changed the units of State_Met%PHIS, so these show up as differences in the StateMet collection. Furthermore: The TransportTracers PR has additional diagnostics not present in the 14.3.0 integration tests, so these show up as differences. |
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR adds three new collections to GCHP
HISTORY.rc
files. These collections are to output the exports of the GCHPctmEnv and FV3 advection gridded components. The upwards mass flux diagnostic which is part of GCHPctmEnv and which was previously included in theLevelEdgeDiags
collection is now in theGCHPctmEnvLevEdge
collection with other exports in that gridded component.Expected changes
This is a no diff update. The new collections will be off by default for all GCHP simulations.
Reference(s)
None
Related PRs (should be brought in at the same time)
Collaborators or others who may be interested in this PR
@sdeastham