Fix bug in transport tracer pressure mask criteria affecting tracer st80_25

[lizziel]

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR changes the pressure mask criteria used to mask sources for transport tracer st80_25. The criteria to mask the source was previously that the grid cell's upper bound was above the target region and the lower bound was below the target region. This effectively prevented the mask from ever being set since no grid cells span the entire target vertical region of 0 to 80 hPa.

The fix changes the criteria to match what is done in GMAO's TR tracer package, checking only that the current grid cell's mid-point pressure is not within the target bounds.

Expected changes

We expect more heterogeneity in the tr80_25 tracer in transport tracer simulations, particularly outside of the source region of 0 to 80 hPa. Outside of that region the source will now be masked.

Reference(s)

None

Related Github Issue(s)

closes #2033

[msulprizio]

Looks great. Thanks for the fix!

[yantosca]

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #88d74e3 Merge PR #53 (Remove obsolete options from CH4 menu in docs)
GEOS-Chem #d085e39ce Merge PR #2226 (Fix bug in pressure mask affecting ST80_25 tracer)
HEMCO     #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 25596892
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GEOS-Chem Classic integration tests are zero-diff w/r/t 14.3.0, except for

• APM (known parallelization issue)
• RRTMG (numerical noise in RRTMG collection)
• TransportTracers (caused by updates in this PR)

[yantosca]

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #dd9375a GEOS-Chem submod update: Merge PR #2218 (Updates for analytical inversions)
GEOS-Chem #d085e39ce Merge PR #2226 (Fix bug in pressure mask affecting ST80_25 tracer)
HEMCO     #2a4bb12 Merge PR #268 (Handle 3D NEI emissions)

Number of execution tests: 6

Submitted as SLURM job: 25597958
==============================================================================
 

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all GCHP integration tests were zero-diff except for:

• TransportTracers (due to changes in this PR)

[lizziel]

Here is an example of before and after the fix. The plot shows st80_25 zonal mean after a 1-month transport tracer run starting on 01 Jan 2019 using MERRA2. Ref is GCHP 14.3.0 (pre-fix) and Dev is GCHP 14.3.1 (post-fix).