Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULL REQUEST] Bug fixes for GEOS-Chem Classic dry-run simulations #661

Merged
merged 5 commits into from Mar 22, 2021

Commits on Mar 16, 2021

  1. Set State_Chm%HetInfo and State_Diag%SpeciesBC to NULL in initialization

    The State_Chm%HetInfo and State_Diag%SpeciesBC fields were never set
    to NULL during initialization.  While this is OK for most simulations,
    when doing a dry-run simulation, this will cause deallocation to fail,
    at least when using GNU Fortran.  This would cause a segmentation fault
    at the end of dry-run simulations (but the dry-run simulations would
    finish otherwise OK).
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Mar 16, 2021
    Copy the full SHA
    17d30ce View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Remove obsolete code from INIT_UCX that caused dry-runs to fail

    File reads have been moved out of the INIT_UCX routine, but there were
    still some print statements left over.  These print statements would
    write that a non-existent file was missing, thus causing dry-runs to
    fail.  We have now removed these extraneous print statements.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Mar 18, 2021
    Copy the full SHA
    6cdd907 View commit details
    Browse the repository at this point in the history
  2. Add updates for download_data.py for proper restart files (incomplete)

    Here we are stashing some modifications to download_data.py for
    downloading restart files for GEOS-Chem 13.0.0.
    
    Will need to work on this further...
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Mar 18, 2021
    Copy the full SHA
    991ca72 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Restore the NOON_FILE_ROOT variable in ucx_mod.F90 as a local variable

    The NOON_FILE_ROOT variable was a module variable that was removed in
    the prior commit 991ca72.  However, this variable is needed to read
    in the UCX boundary conditions in routine NOXCOEFF_INIT.
    
    We have now restored NOON_FILE_ROOT as a local variable to NOXCOEFF_INIT.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Mar 19, 2021
    Copy the full SHA
    b872b6d View commit details
    Browse the repository at this point in the history
  2. Further fixes for the GEOS-Chem Classic dry run

    (1) run/GCClassic/createRunDir.sh:
     - Aerosol simulations now use the fullchem restart file
     - POPs simulation now looks for an initial restart file w/ the extra
       option (BaP, PYR, PHE) in ExtData/GEOSCHEM_RESTARTS/v2020-02
     - All other specialty simulations use restart files in
       GEOSCHEM_RESTARTS/v2020-02 on the remote server
     - Send error output from aws s3 cp to dev/null
    
    (2) run/shared/download_data.py
     - Look for NK15 and NK40 in input.geos to decide if we are
       need to download data files for TOMAS15 and TOMAS40 simulations
     - Use the fullchem restart file (Jan 2019) for the aerosol simulation
     - Look for specialty simulation restart files in GEOSCHEM_RESTARTS/v2020-02
     - When downloading data from ComputeCanada, first download it to
       the local GEOSCHEM_RESTARTS directory tree, then copy it to the
       run directory.
     - AWS restart files should now be placed in the run directory by
       createRunDir.sh.  But if a restart file is missing, running
       download_data.py with -aws will restore it.
    
    NOTE: There may still be an issue with the POPs restart files on AWS,
    but since POPs is not used by many people I am not sure if we want
    to end up fixing this.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Mar 19, 2021
    Copy the full SHA
    378e79e View commit details
    Browse the repository at this point in the history