Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PULL REQUEST] ClNO2 + {SALACL,SALCCL,HCL} hetchem rxns should yield HNO2, not HNO3 #914

Merged
merged 1 commit into from Sep 27, 2021
Merged

[PULL REQUEST] ClNO2 + {SALACL,SALCCL,HCL} hetchem rxns should yield HNO2, not HNO3 #914

merged 1 commit into from Sep 27, 2021

Conversation

yantosca
Copy link
Contributor

This is the corresponding PR to Bug Report #841. See the discussion there.

@yantosca
ClNO2 + {SALACL,SALCCL,HCL} hetchem rxns should yield HNO2, not HNO3
14dca24 
This commit addresses the issue raised in geoschem/geos-chem #841

The following hetchem reactions:

 ClNO2 + SALACL
 ClNO2 + SALCCL
 ClNO2 + HCl

should all yield as products Cl2 + HNO2, but the reactions as listed
yielded Cl2 + HNO3.  The KPP equation files have now been updated
and the fullchem mechanism files regenerated.

KPP/aciduptake/aciduptake.eqn
KPP/fullchem/fullchem.eqn
- Fixed erroneous ClNO2 hetchem rxns described above

KPP/fullchem/gckpp.map
KPP/fullchem/gckpp_*.F90
- Rebuilt with KPP 2.3.3_gc

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Bug Something isn't working topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms labels Sep 24, 2021
@yantosca yantosca added this to the 13.3.0 milestone Sep 24, 2021
@yantosca yantosca self-assigned this Sep 24, 2021
@yantosca yantosca linked an issue Sep 24, 2021 that may be closed by this pull request
[BUG] Typo in fullchem.eqn in KPP/fullchem #841
Closed
msulprizio
msulprizio approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. I approve the merge into dev.

@yantosca yantosca merged commit ef447ce into dev Sep 27, 2021
@yantosca yantosca deleted the bugfix/ClNO2_hetchem branch September 27, 2021 15:49
@yantosca Octobox
Copy link
Contributor Author

Now merged and tagged with 13.3.0-alpha.6

@yantosca
Copy link
Contributor Author 

geosfp_025x03125_fullchem_na_47L.................Execute Simulation.....FAIL
merra2_05x0625_CH4_na_47L........................Execute Simulation.....PASS
merra2_05x0625_fullchem_as_47L...................Execute Simulation.....FAIL
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 78
Execution tests failed: 2
Execution tests not yet completed: 0

Everything except the bigger nested-grid tests failed. Might be a memory issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msulprizio msulprizio msulprizio approved these changes

Assignees

@yantosca yantosca

Labels
category: Bug Something isn't working topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Milestone
13.3.0
Development

Successfully merging this pull request may close these issues.

[BUG] Typo in fullchem.eqn in KPP/fullchem
2 participants
@yantosca @msulprizio