[PULL REQUEST] Update IONO2 hydrolysis following Wang et al 2021 (supersedes PR #719) #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPP/fullchem/fullchem.eqn KPP/aciduptake/aciduptake.eqn - Remove hetchem rxns HOI = ISALA and HOI = ISALC - Remove hetchem rxns IONO = ISALA and IONO = ISALC - Remove hetchem rxns IONO2 = ISALA and IONO2 = ISALC - Add hetchem rxn IONO2 + H2O = HOI + HNO3 KPP/fullchem/RateLawFuncs.F90 - Add new hetrate function IONO2uptkByH2O, following the instructions in geoschem/geoschem #719 KPP/fullchem/gckpp.map KPP/fullchem/gckpp_*.F90 - Rebuilt with KPP 2.3.3_gc NOTE: There may be a bug in the original code as received from T. Sherwen, we are asking for clarification. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merges the 13.3.0-alpha.6 code into the previous IONO2 hydrolysis code. Rebuilt the KPP mechanism with KPP version 2.3.3_gc. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
In the original geoschem/geos-chem PR #719, the gammaLiq and gammaIce values for IONO2 were not specified in routine CloudHet. This was a bug in the original development branch. Tomas Sherwen and Xuan Wang have clarified that the values of gammaLiq and gammaIce for IONO2 should both be 0.01. We now pass these to the CloudHet function in rate law function IONO2uptkByH2O in KPP/fullchem/fullchem_RateLawFuncs.F90. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Feature Request
|
Integration tests pending |
msulprizio
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Thanks @yantosca for merging this PR. These changes do look straightforward to me -- modifying a few reactions in the .eqn file and adding a new function for IONO2 uptake by H2O to fullchem_RateLawFuncs.F90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the update to IONO2 hydrolysis originally implemented in PR #719.
The code in the original PR no longer exists in the current GEOS-Chem (after implementation of the new hetchem rate functions), so I had to take the algorithms from the original PR and manually apply them into the new code base.
This PR now supersedes #719. Please see the original PR for the discussion thread.