Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes CMake error message for when NetCDF is not found #94

Closed

Conversation

LiamBindle
Copy link
Contributor

@LiamBindle LiamBindle commented Oct 15, 2019

This PR makes the following difference to the error message CMake prints when NetCDF isn't found on the host.

CMake Error at /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
+
+  Counldn't find one or more of NetCDF's files! The following
+  files/directories weren't found:

      NETCDF_F_LIBRARY: Path to "libnetcdff.so"
      NETCDF_C_LIBRARY: Path to "libnetcdf.so"
      NETCDF_C_INCLUDE_DIR: Directory containing "netcdf.h"
      NETCDF_F90_INCLUDE_DIR: Directory containing "netcdf.mod"
      NETCDF_F77_INCLUDE_DIR: Directory containing "netcdf.inc"

  Find the directories/files that are listed above.  Specify the directories
  you want CMake to search with the CMAKE_PREFIX_PATH variable (or the
  NetCDF_ROOT environment variable).

   (missing:  NETCDF_F_LIBRARY NETCDF_C_LIBRARY NETCDF_C_INCLUDE_DIR NETCDF_F90_INCLUDE_DIR NETCDF_F77_INCLUDE_DIR) 
Call Stack (most recent call first):
  /usr/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:388 (_FPHSA_FAILURE_MESSAGE)
  CMakeScripts/FindNetCDF.cmake:138 (find_package_handle_standard_args)
  CMakeLists.txt:44 (find_package)


 -- Configuring incomplete, errors occurred!
 See also "/stetson-home/bindle/geos-chem/build/CMakeFiles/CMakeOutput.log".

…the error message was getting put in the wrong variable.
@msulprizio
Copy link
Contributor

Now merged into dev/12.6.1

@msulprizio msulprizio closed this Oct 15, 2019
@yantosca yantosca deleted the bugfix/bad-unfound-netcdf-cmake-error-message branch October 16, 2019 14:47
@yantosca yantosca added category: Bug Something isn't working waiting for release labels Oct 18, 2019
@yantosca yantosca added this to the 12.6.1 milestone Oct 18, 2019
@yantosca
Copy link
Contributor

Now included in GC 12.6.1, released on 28 Oct 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants