New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PULL REQUEST] Added support for driving GEOS-Chem with native GEOS meteorological files #945
Conversation
2de1ca6
to
e593ccb
Compare
This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all straightforward changes. We can get this into 13.4.0.
I have merged these updates on top of 13.4.0-alpha.9 and stored them in a temporary branch: |
GCHP integration tests all passed ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
I still need to review this. |
No worries, just queueing up the runs before the holiday. |
All GC-Classic integration tests passed. Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 80
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
GCHPctmEnv: | ||
level: WARNING | ||
root_level: INFO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this logger is used in this update. Is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizziel, @LiamBindle: Is it OK if I merge this PR and we can fix this later?
The GEOS-Chem Classic benchmark for this update (tagged as 13.4.0-alpha.10) is now ready:
OH metrics change very slightly: ###############################################################################
### OH Metrics
### Ref = GCC_13.4.0-alpha.9; Dev = GCC_13.4.0-alpha.10
###############################################################################
------------------------------------------------------------
Global mass-weighted OH concentration [10^5 molec cm^-3]
------------------------------------------------------------
Ref : 11.74075147575
Dev : 11.73996703152
Abs diff : -0.00078444423
% diff : -0.006681
------------------------------------------------------------
CH3CCl3 (aka MCF) lifetime w/r/t tropospheric OH [years]
------------------------------------------------------------
Ref : 5.270215
Dev : 5.270799
Abs diff : 0.000584
% diff : 0.011080
------------------------------------------------------------
CH4 lifetime w/r/t tropospheric OH [years]
------------------------------------------------------------
Ref : 8.880780
Dev : 8.881782
Abs diff : 0.001003
% diff : 0.011291 There are also small changes near the poles due to removing albedo as a proxy for snow/ice. |
There are two changes included in this PR:
IsLand
,IsSnow
,IsWater
, andIsIce
flags based on FRLAND, FRSNO, FRLANDIC, FRLAKE, FROCEAN, and FRSEAICE.METEOROLOGY_VERTICAL_INDEX_IS_TOP_DOWN
switch toGCHP.rc
. Set this flag to.true.
if you want to flip all 3D meteorological fields at import-time.Parent PR (feature/native-metfields)