[PULL REQUEST] Add PM10 diagnostic according to suggestions from Aerosols WG (Closes #958) #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol_mod.F90 - Point users to the GEOS-Chem wiki for the most up-to-date definition of PM2.5 and PM10 - Make sure that numerical constants use "_fp", i.e. change 0.3, 0.7, and 0.9 to 0.3_fp, 0.7_fp, 0.9_fp - Cosmetic changes, trimmed trailing whitespace Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/GCClassic/HISTORY.rc.templates/HISTORY.rc.fullchem run/GCClassic/HISTORY.rc.templates/HISTORY.rc.aerosol run/GCHP/HISTORY.rc.templates/HISTORY.rc.fullchem - Add PM10 to the AerosolMass collection GeosCore/aerosol_mod.F90 - Updated comment Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Feature Request
|
Integration tests are in progress. |
|
GCHP integration tests passed ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
|
I re-ran the GC-Classic integration tests and they all passed. Several jobs had failed previously but this was an issue with our scratch disk and nothing to do with GEOS-Chem. Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 80
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corresponding PR to #958. We have added a PM10 diagnostic following the recommendations of the GEOS-Chem Aerosols Working Group. For more information, please see http://wiki.geos-chem.org/Particulate_matter_in_GEOS-Chem.