(LATEST) Updated the people.html file for certain GCSC entries #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msulprizio
requested changes
Aug 7, 2023
| @@ -437,7 +440,7 @@ <h1 id="page-title" ng-non-bindable="">GEOS-Chem People and Projects </h1> | |||
| L.marker([34.201467774645586, -118.17093305334618], { icon: greenIcon }).addTo(mymap).bindPopup("<a href='#jpl'><strong>NASA Jet Propulsion Laboratory<br>Pasadena, California, USA</strong></a>"); | |||
|
|
|||
| // NASA Langley Research Center Hampton, Virginia, USA | |||
| L.marker([37.096175668285525, -76.38332286758234], { icon: greenIcon }).addTo(mymap).bindPopup("<a href='#langley'><strong>NASA Langley Research Center<br>Hampton, Virginia, USA</strong></a>"); | |||
| L.marker([37.096175668285525, -76.38332286758234], { icon: greenIcon }).addTo(mymap).bindPopup("<a href='#langley'><strong>NASA Langley Research Center<br>Hampton, Virginia, USA</strong></a><ul><li>Research Group of T. Duncan Fairlie</li><li>Research Group of Katherine Travis</li></ul>"); | |||
There was a problem hiding this comment.
@SaptSinha Could you please remove the line for Duncan. He is no longer with us.
| @@ -8151,6 +8259,9 @@ <h2> | |||
|
|
|||
| <tr> | |||
| <td> | |||
| <h3> | |||
| Research Group of T. Duncan Fairlie | |||
There was a problem hiding this comment.
Please also remove this line.
1 task
|
Opening a new PR and deleting this one and its branch due to re-submission errors & for incorporating more changes .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Saptarshi Sinha
Institution: Washington University in St. Louis
Confirm you have reviewed the following documentation
Describe the update
Per Randall's request, I corrected some of the prior GCSC entries and added a few new ones.
NOTE: I submitted a pull request earlier but had to close it, and deleted the corresponding branch. Please ignore any email/pull request you may have received for the branch people_August_4_2023.
Expected changes
The GCSC entries, both in the map and in the information section, would be updated upon merging.
Related Github Issue(s)
Not applicable.