Bugfix/get num statevector elements #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on AWS and confirmed no differences (except for the removal of some trailing whitespace) |
msulprizio
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
ncmaxandncminfunctions (addressing #123) and puts them in thecommon.shfile. The behavior of the updated function is the same except that it uses python instead of ncap2. ncap2 requires significantly more memory and caused a constraint on the amount of memory that could be used to run the IMI.Additionally, I remove the
setup_imi.shfile because this is a vestigial file. Setup is now handled bysrc/components/setup_component/setup.sh.