Make sure there are not duplicate TROPOMI files #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laestrada
reviewed
May 24, 2023
src/utilities/test_TROPOMI_dir.py
Outdated
| number_of_unique_orbit_numbers = len(set(all_orbit_numbers)) # forming a set drops the duplicates | ||
| number_of_files_in_Sat_datadir = len(files) | ||
|
|
||
| assert number_of_unique_orbit_numbers == number_of_files_in_Sat_datadir, "There are duplicate TROPOMI datafiles (as defined by their orbit number)." |
There was a problem hiding this comment.
Maybe update this to give more guidance? Eg. Error: Duplicate orbit numbers found in TROPOMI datafiles. Remove duplicate files from system before continuing.
Also, does assert trigger a non-zero exit code? Does the IMI exit when it hits this error?
There was a problem hiding this comment.
I'm not sure what you mean by a non-zero exit code. The IMI does exit when it hits this error.
=== PARSING CONFIG FILE (run_imi.sh) ===
Activating conda environment: imi_env
mkdir: created directory ‘/n/holyscratch01/jacob_lab/nbalasus/Test_IMI’
Traceback (most recent call last):
File "/n/home06/nbalasus/IMI_test_tropomi_duplicates/integrated_methane_inversion/src/utilities/test_TROPOMI_dir.py", line 27, in <module>
check_for_duplicate_orbit_numbers(Sat_datadir)
File "/n/home06/nbalasus/IMI_test_tropomi_duplicates/integrated_methane_inversion/src/utilities/test_TROPOMI_dir.py", line 23, in check_for_duplicate_orbit_numbers
assert number_of_unique_orbit_numbers == number_of_files_in_Sat_datadir, "Duplicate orbit numbers found in TROPOMI datafiles. Remove duplicate files from system before continuing."
AssertionError: Duplicate orbit numbers found in TROPOMI datafiles. Remove duplicate files from system before continuing.
FATAL ERROR on line number 126 of slurm_script: IMI exiting.
There was a problem hiding this comment.
Okay perfect, thanks.
FYI It is standard practice when running a program to exit(0) upon successful completion. Non-zero exit codes denote an error. We have a line in run_imi.sh (trap 'imi_failed $LINENO' ERR) that catches any non-zero exit codes and calls a standard error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue in the past where
download_TROPOMI.pywould result in users having duplicate TROPOMI files (e.g., two files with orbit number xxxxx, but one with processor version 02.04.00 and one with processor version 01.03.00). This simple and fast test should prevent this in the future as processor version numbers continue to change.