Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix to only turn on extra observation switches for prior and posterior runs #131

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

sabourbaray
Copy link
Contributor

Name and Institution (Required)

Name: Sabour Baray
Institution: Environment and Climate Change Canada

Describe the update

For the extra observation operators (GOSAT, TCCON, AIRS, Planeflight), currently the IMI switches them on in the template run, which is used to update the geoschem_config.yml files in all run directories. Users will likely only use these comparisons for the base run and posterior run, so we can save computational cost by not running these operators for each jacobian run.

Copy link
Collaborator

@laestrada laestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabourbaray This is a great idea. Thanks for making the PR. My only comment is that perhaps we should make this a function (eg. activate_observations) that lives in either common.sh or setup.sh. Then call the function in both jacobian.sh and posterior.sh.

sed -i "s/$OLD/$NEW/g" geoschem_config.yml
fi
if "$PLANEFLIGHT"; then
mkdir -p Plane_Logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, but the spacing is inconsistent here

@sabourbaray
Copy link
Contributor Author

@sabourbaray This is a great idea. Thanks for making the PR. My only comment is that perhaps we should make this a function (eg. activate_observations) that lives in either common.sh or setup.sh. Then call the function in both jacobian.sh and posterior.sh.

Hi Lucas, I've added both of the suggested changes. The function activate_observations is in setup.sh where I think it will be easier to find when setting up the directories.

Copy link
Collaborator

@laestrada laestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge -- thanks Sabour!

@laestrada laestrada merged commit 018735e into geoschem:dev Jun 21, 2023
@msulprizio msulprizio added this to the IMI 1.2.1 milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants