-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maxwell fundamental edits #480
Conversation
…z/em into MaxwellFundamentalEdits Conflicts: content/maxwell1_fundamentals/index.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @dccowan, I particularly like the overview of Maxwell's equations! I have done a once over lightly focussing on organization. Please have a look at my comments and see what you think.
I also would really appreciate if you could give a few more specifics in the description of the pull request with respect to what you changed - there are a lot of differences in the file diff. It looks like some are organization, some addition of content etc - a few pointers on what you did would be very helpful for giving a bit more targeted feedback and informing the rest of the team.
Please let me know if there is anything you would like to chat about!
.. The final section, :ref:`Looking for More | ||
.. <fundamentals_looking_for_more>` presents detailed information and additional | ||
.. topics of general relevance to EM. | ||
Here, the fundamentals of electromagnetism are presented. For those who do not have a strong background in electromagnetism, the content provided here is an excellent place to start within EM GeoSci. After reading through *Maxwell I: Fundamentals*, you will be able to understand the physical principles which govern :ref:`static problems<maxwell2_static_index>`, :ref:`frequency domain electromagnetics<maxwell3_fdem_index>` and :ref:`time domain electromagnetics<maxwell4_tdem_index>` as well as the :ref:`survey methods<geophysical_surveys_index>` used in electromagnetic geoscience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for all of the links!
|
||
- :ref:`Dipole Sources in Homogeneous Media<dipole_sources_in_homogeneous_media_index>`: The fields generated by dipole sources and of great fundamental important to electromagnetic geoscience, as they do very well at approximating the electromagnetic sources used for many geophysical applications. Here, the fields generated by dipole sources within a homogeneous medium are presented. Numerical apps are provided for visualizing the fields. | ||
|
||
- :ref:`Solving Maxwell's Equations in Practice<solving_maxwells_equations>`: Here, we discuss what is needed to solve Maxwell's equations in practice. | ||
|
||
**Contents** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding titles: to tighten things up, here is my suggestion, see what you think (cc @dougoldenburg )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that's fine. I made the changes.
|
||
**Contents** | ||
Contents | ||
-------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navigation here is a bit tricky (the "Contents" and having titles with brackets is potentially quite confusing).
I would instead suggest:
- Plane Waves in Homogeneous Media
- Intro
- setup
- solving
- frequency domain (show the Analytic solution on the index page)
- fields
- analytic solution
- time domain (show the Analytic solution on the index page)
- fields
- analytic solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to make something pretty much the same as this. I agree that it is better now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did something similar for interface conditions
LATEST CONTENT:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates @dccowan! There are a couple minor request I have prior to merging. These are stated in individual comments. Please have a look and let me know if anything is unclear.
There are a few other items that are worth discussing, but I think these can be summarized in an issue and discussed with the group cc @dougoldenburg, @sgkang after merging. Here are my thoughts after a once-over-lightly, these are up for debate!
- In the overview of Maxwell's equations, do we want to include a source term? or clarify that we are not including a source
- Interface conditions: there is duplication between e, d and I think the specification of j at steady state is unnecessary here
- In solving Maxwell's equations, I would be inclined to start from the first-order equations and derive the second order equations - This makes it a bit more complete and also shows how you can still get b-field data when you solve for e, for instance. (Along the same lines as the EM paper: https://arxiv.org/pdf/1610.00804.pdf - we can pull content from here as long as it is cited)
- **Free Surface Current Density** (:math:`K_f`): The free surface current per unit area on the interface. Occurs due to discontinuities in the tangential component of the magnetic field across the interface. | ||
|
||
|
||
Derivation of Interface Conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including this title here creates an extra layer of depth to the table of contents that I think is likely confusing.
I would suggest replacing
Derivation of Interface Conditions
----------------------------------
with
**Contents**
as that is what we have used elsewhere for listing tables of contents. Also, using Bold does not introduce a new layer in the table of contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Regardless of whether there are source terms or not, Maxwell's equations in the quick links section is correct. By introducing a source term, all we are doing is separating the current density (for example) into a primary and a secondary contribution. I see no reason to change it but we could mention that we will discuss sources later and provide the link.
- I feel that the table looks better if, for whatever variable you put in, there is both parallel and perpendicular interface conditions. It means that the reader does not have to infer interface conditions for one variable from another. In regards to the current density, I kept being told how important it was to include interface conditions for DC resistivity here. That's what I did. And this particular simplification for j is only valid for steady-state. A derivation was provided.
- In "solving maxwell's equations", I think you and Doug are kind of missing the point of what I am trying to present. I want to keep it short. I don't want to derive anything which makes the page longer. The intent is for the reader to learn 1) Maxwell's equations can be re-formulated, simplified or approximated for practical use and 2) here are a few examples that you will run into.
- I made the change to the way the interface conditions derivation is listed (using contents instead).
- Added link for N-layered Earth. Great catch!
|
||
- :ref:`Reflection and Snell's Law<Snells_law>`: Defines the relationship between the propagation directions of incident, reflected and refracted EM waves. | ||
- :ref:`Fresnel Equations<Fresnel_equations>`: Defines the relationships between the propagation directions and amplitudes of incident, reflected, refracted and transmitted EM waves. | ||
- N-Layer Earth: After characterizing the behaviours of plane waves at a single interface, we extend the theory to a layered Earth model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind adding a link to this title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dccowan!!
Maxwell 1: Fundamentals branch has been review by @lheagy and merged. |
Pulling in Maxwell fundamentals. Some stuff with visualization needs to be done later.