[backport] Fix GWC not storing tiles on disk when using pgconfig catalog backend #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `pgconfig` catalog backend, it replaces the default GWC tile layer catalog with a specialized one to store the tile layers config directly on the database instead of going through the resource store. To do so, it has to exclude the `GWCInitializer` bean, as it depends on a `TileLayerCatalog`. By doing so, we missed the call to `ConfigurableBlobStore.setChanged(...)`, resulting in the `ConfigurableBlobStore` decorator never having its `configured` flag set to true, and hence never calling the actual `BlobStore`'s `put(TileObject)` method. This patch introduces `PgsqlGwcInitializer` as a replacement for the default `GWCInitializer`, which takes care of that and also listens to `TileEvents` to maintain the non-memory-cacheable list of layers in sync at `org.geowebcache.storage.blobstore.memory.CacheProvider`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
pgconfigcatalog backend, it replaces the default GWC tile layer catalog with a specialized one to store the tile layers config directly on the database instead of going through the resource store.To do so, it has to exclude the
GWCInitializerbean, as it depends on aTileLayerCatalog.By doing so, we missed the call to
ConfigurableBlobStore.setChanged(...), resulting in theConfigurableBlobStoredecorator never having itsconfiguredflag set to true, and hence never calling the actualBlobStore'sput(TileObject)method.This patch introduces
PgsqlGwcInitializeras a replacement for the defaultGWCInitializer, which takes care of that and also listens toTileEventsto maintain the non-memory-cacheable list of layers in sync atorg.geowebcache.storage.blobstore.memory.CacheProvider.