[GEOS-7516] Resource Browser (ResourceStore GUI) #1572

NielsCharlier · 2016-04-18T16:02:22Z

GSIP 139 - GeoServer Resource Browser GUI
https://github.com/geoserver/geoserver/wiki/GSIP-139

[GEOS-7516] Resource Browser (ResourceStore GUI)
https://osgeo-org.atlassian.net/browse/GEOS-7516

jodygarnett · 2016-04-18T16:25:56Z

We tend not to worry too much about community modules - as long as they do not break the build. They get a review when being considered for extension (or integration with a main module).

That said this pull request also includes changes to core modules, can you split the two pull requests into two please - I would like to have a better look at what you needed to change.

My initial take ResourceAdaptor has been changed to always use absolute paths, which has had a ripple on effect to utility methods and test cases. Can I ask you to start a seperate email thread and we can sort out how to report the issue you are fixing and an appropriate fix.

NielsCharlier · 2016-04-19T08:13:07Z

Jody, the first commit has a separate PR and JIRA issue #1565. https://osgeo-org.atlassian.net/browse/GEOS-7493 where it can be discussed.

The commit is just on this branch as well because I needed it to work.

jodygarnett · 2016-04-20T14:36:00Z

Remove JAI from the Mac java extensions for the user. See other email
thread for the path.
On Tue, Apr 19, 2016 at 1:13 AM NielsCharlier notifications@github.com
wrote:

Jody, the first commit has a separate PR and JIRA issue #1565
#1565.

The commit is just on this branch as well because I needed it to work.
https://osgeo-org.atlassian.net/browse/GEOS-7493 It can be discussed there

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1572 (comment)

Jody Garnett

bencaradocdavies · 2016-04-20T21:56:07Z

The other PR #1565 is merged.

bencaradocdavies · 2016-04-20T22:07:42Z

@NielsCharlier is there an OSGeo Jira issue for this so that it gets in the release notes?

NielsCharlier · 2016-04-21T10:19:07Z

@jodygarnett Jody I don't understand your comment and I do not know what you are referring to.

bencaradocdavies · 2016-04-21T20:21:50Z

@NielsCharlier thanks for the Jira issue. I added a link in the PR description.

bencaradocdavies · 2016-05-05T22:50:54Z

@NielsCharlier this PR now has conflicts. Please update it.

bencaradocdavies · 2016-05-23T02:48:05Z

src/community/web-resources/pom.xml

+  <parent>
+    <groupId>org.geoserver</groupId>
+    <artifactId>community</artifactId>
+    <version>2.9-SNAPSHOT</version>


@NielsCharlier the parent version must now be 2.10-SNAPSHOT as the 2.9.x branch was created when 2.9-RC1 was released, while you were waiting for me to review this issue. Apologies for the inconvenience.

bencaradocdavies · 2016-05-23T05:29:52Z

...munity/web-resources/src/main/resources/org/geoserver/web/resources/styleResourceBrowser.css

+
+.menu a #delete {
+  background-image: url("icons/delete.png");
+}


Missing new line at end of file.

bencaradocdavies · 2016-05-23T05:31:53Z

OK, @NielsCharlier I am going to stop whinging about the missing newlines at the end of all your test resources. Please fix them all to improve maintainability. Many text editors add missing newlines at the end causing spurious commits.

bencaradocdavies · 2016-05-23T05:32:21Z

@NielsCharlier, what is the source of the icons and what is their licence? This must be documented.

bencaradocdavies · 2016-05-23T05:39:07Z

@NielsCharlier every other extension I could find except charts and vectortiles uses the singular not plural form. This is I think a great plugin that is destined for promotion. I would love it (and its profile) to be renamed from web-resources to web-resource.

bencaradocdavies · 2016-05-23T05:43:19Z

@NielsCharlier, other than my truckload of small comments and questions, this is looking very good: clean and thoroughly tested. Not much character development, but a gripping read. It also builds cleanly (with pom version fixes applied locally). I will now start manual testing and report back. I also want to compare it to the GSIP, which although is not strictly needed for a community module, elicited a great deal of good quality feedback.

bencaradocdavies · 2016-05-24T03:25:17Z

@NielsCharlier I have done some manual testing and recorded my findings here:
https://osgeo-org.atlassian.net/browse/GEOS-7516

bencaradocdavies · 2016-05-24T09:24:05Z

...munity/web-resources/src/main/resources/org/geoserver/web/resources/PageResourceBrowser.html

+        <div wicket:id="dialog"></div>
+
+        <div class="menu-wrapper">
+	        <div class="menu">


Many tabs here, mixing tabs and spaces.

NielsCharlier · 2016-06-10T09:49:01Z

@bencaradocdavies this is pending review again (there is no rush, but making sure you are aware ;) )

bencaradocdavies · 2016-06-10T11:06:53Z

@NielsCharlier this one is slowly moving up my to-do list. :-)

jodygarnett · 2016-06-14T20:11:30Z

How is your todo list looking @bencaradocdavies :)

bencaradocdavies · 2016-06-14T20:43:25Z

@jodygarnett I should be able to complete reviewing this PR in the next couple of days.

bencaradocdavies · 2016-06-16T22:15:13Z

Working on this now. There are a couple of tiny pom conflicts with the ncwms commit; I will fix them.

bencaradocdavies · 2016-06-18T01:31:09Z

...mmunity/web-resource/src/main/resources/org/geoserver/web/resources/styleResourceBrowser.css

+.treeview {	
+    height: calc(100vh - 325px);
+    width: 100%;
+	overflow-y: scroll;


@NielsCharlier you fixed most tabs but sneaked in a few more. :-)

I will fix before merging as I have to deal the pom conflicts.

bencaradocdavies · 2016-06-18T02:24:15Z

@NielsCharlier that looks great. Very thorough work. I think you fixed every single thing I mentioned!

A full build passed, and I did a bit more manual testing. I think your new always-visible toolbar is a big usability improvement as it can be accessed without scrolling when the tree view is expanded.

The additional tiny changes I made were:

Fixed pom merge conflicts (@aaime merged ncwms while you were waiting for me)
Removed one new trailing tab and converted two new tabs to spaces
Added "htm" to the list of textual format file name extensions

I have pushed the resulting commit to master:
2d2c47a

My only unanswered question is the source of the icons, which would be nice to know as their provenance should be documented.

Thanks again for your patience.

Kind regards,
Ben.

NielsCharlier · 2016-06-20T08:50:05Z

@bencaradocdavies thanks! Considering the icons, unfortunately I cannot find where I got them any more, I believe they were creativecommons / free for commercial use but I lost the source. Should they perhaps be replaced by other icons from which we know the source?

bencaradocdavies · 2016-06-21T03:05:01Z

@NielsCharlier I agree that these icons must be replaced with icons whose source is known. The licence must be GPL-compatible, including use for any purpose and the right to modify and redistribute modifications. CC BY is OK, I think any CC NC or CC ND cannot be used. Not sure about CC SA. CC suggest that it is compatible: https://wiki.creativecommons.org/wiki/ShareAlike_compatibility_analysis:_GPL

jodygarnett · 2016-06-21T06:15:04Z

Where are the icons, can I draw us something that matches our "geoslik" style?

bencaradocdavies · 2016-06-21T06:31:46Z

@jodygarnett you can see the icons in this pull request or you can browse them as merged on master:
https://github.com/geoserver/geoserver/tree/master/src/community/web-resource/src/main/resources/org/geoserver/web/resources/icons

I welcome contributions from those with artistic talent or aspirations. :-)

NielsCharlier · 2016-06-21T16:18:32Z

Absolutely!

NielsCharlier · 2016-06-22T11:54:37Z

So Jody are you doing this (no point in me downloading new ones then)?

jodygarnett · 2016-06-22T18:51:46Z

Reviewing that list I see no geospatial specific icons, so we should pull from geosilk.

The geosilk includes geosilk and silk icons.

The original silk project is under a reative Commons Attribution 2.5 or 3.0 License with the following requirements:

As an author, I would appreciate a reference to my authorship of the Silk icon set contents within a readme file or equivalent documentation for the software which includes the set or a subset of the icons contained within.

Will update with what I find/draw.

bencaradocdavies self-assigned this Apr 20, 2016

NielsCharlier changed the title ~~Resource Browser (ResourceStore GUI)~~ GEOS-7516 Resource Browser (ResourceStore GUI) Apr 21, 2016

bencaradocdavies changed the title ~~GEOS-7516 Resource Browser (ResourceStore GUI)~~ [GEOS-7516] Resource Browser (ResourceStore GUI) Apr 21, 2016

NielsCharlier force-pushed the webresources branch from 48d1f9d to 1293d4a Compare May 6, 2016 09:08

bencaradocdavies reviewed May 23, 2016
View reviewed changes

bencaradocdavies reviewed May 24, 2016
View reviewed changes

NielsCharlier force-pushed the webresources branch from 1293d4a to b8f405d Compare May 30, 2016 09:44

Resource Browser (ResourceStore GUI)

c7a33d9

NielsCharlier force-pushed the webresources branch from b8f405d to c7a33d9 Compare May 30, 2016 10:07

bencaradocdavies reviewed Jun 18, 2016
View reviewed changes

bencaradocdavies closed this Jun 18, 2016

NielsCharlier deleted the webresources branch August 16, 2016 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GEOS-7516] Resource Browser (ResourceStore GUI) #1572

[GEOS-7516] Resource Browser (ResourceStore GUI) #1572

NielsCharlier commented Apr 18, 2016 •

edited by bencaradocdavies

jodygarnett commented Apr 18, 2016

NielsCharlier commented Apr 19, 2016 •

edited

jodygarnett commented Apr 20, 2016

bencaradocdavies commented Apr 20, 2016

bencaradocdavies commented Apr 20, 2016

NielsCharlier commented Apr 21, 2016

bencaradocdavies commented Apr 21, 2016 •

edited

bencaradocdavies commented May 5, 2016

bencaradocdavies May 23, 2016 •

edited

bencaradocdavies May 23, 2016

bencaradocdavies commented May 23, 2016

bencaradocdavies commented May 23, 2016 •

edited

bencaradocdavies commented May 23, 2016

bencaradocdavies commented May 23, 2016 •

edited

bencaradocdavies commented May 24, 2016

bencaradocdavies May 24, 2016

NielsCharlier commented Jun 10, 2016

bencaradocdavies commented Jun 10, 2016

jodygarnett commented Jun 14, 2016

bencaradocdavies commented Jun 14, 2016

bencaradocdavies commented Jun 16, 2016

bencaradocdavies Jun 18, 2016

bencaradocdavies commented Jun 18, 2016 •

edited

NielsCharlier commented Jun 20, 2016

bencaradocdavies commented Jun 21, 2016

jodygarnett commented Jun 21, 2016

bencaradocdavies commented Jun 21, 2016

NielsCharlier commented Jun 21, 2016

NielsCharlier commented Jun 22, 2016

jodygarnett commented Jun 22, 2016

[GEOS-7516] Resource Browser (ResourceStore GUI) #1572

[GEOS-7516] Resource Browser (ResourceStore GUI) #1572

Conversation

NielsCharlier commented Apr 18, 2016 • edited by bencaradocdavies

jodygarnett commented Apr 18, 2016

NielsCharlier commented Apr 19, 2016 • edited

jodygarnett commented Apr 20, 2016

bencaradocdavies commented Apr 20, 2016

bencaradocdavies commented Apr 20, 2016

NielsCharlier commented Apr 21, 2016

bencaradocdavies commented Apr 21, 2016 • edited

bencaradocdavies commented May 5, 2016

bencaradocdavies May 23, 2016 • edited

Choose a reason for hiding this comment

bencaradocdavies May 23, 2016

Choose a reason for hiding this comment

bencaradocdavies commented May 23, 2016

bencaradocdavies commented May 23, 2016 • edited

bencaradocdavies commented May 23, 2016

bencaradocdavies commented May 23, 2016 • edited

bencaradocdavies commented May 24, 2016

bencaradocdavies May 24, 2016

Choose a reason for hiding this comment

NielsCharlier commented Jun 10, 2016

bencaradocdavies commented Jun 10, 2016

jodygarnett commented Jun 14, 2016

bencaradocdavies commented Jun 14, 2016

bencaradocdavies commented Jun 16, 2016

bencaradocdavies Jun 18, 2016

Choose a reason for hiding this comment

bencaradocdavies commented Jun 18, 2016 • edited

NielsCharlier commented Jun 20, 2016

bencaradocdavies commented Jun 21, 2016

jodygarnett commented Jun 21, 2016

bencaradocdavies commented Jun 21, 2016

NielsCharlier commented Jun 21, 2016

NielsCharlier commented Jun 22, 2016

jodygarnett commented Jun 22, 2016

NielsCharlier commented Apr 18, 2016 •

edited by bencaradocdavies

NielsCharlier commented Apr 19, 2016 •

edited

bencaradocdavies commented Apr 21, 2016 •

edited

bencaradocdavies May 23, 2016 •

edited

bencaradocdavies commented May 23, 2016 •

edited

bencaradocdavies commented May 23, 2016 •

edited

bencaradocdavies commented Jun 18, 2016 •

edited