[GEOS-10813] -- jdbcconfig cache bug,changed the workspace name

[Tian-geer]

See jira ticket for details.

Checklist

• I have read the contribution guidelines.
• I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• First PR targets the main branch (backports managed later; ignore for branch specific issues).
• All the build checks are green (see automated QA checks).

For core and extension modules:

• New unit tests have been added covering the changes.
• Documentation has been updated (if change is visible to end users).
• The REST API docs have been updated (when changing configuration objects or the REST controllers).
• There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
• Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
• Bug fixes and small new features are presented as a single commit.
• Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

[aaime]

@NielsCharlier or @groldan could you have a look?

[sikeoka]

I tested this and it seems to work but could you add a line in the comments to explain why changing the priority is fixing this problem?

[Tian-geer]

Because the cache is cleared in 【CatalogClearingListener】, but oldName is cached again in 【NamespaceWorkspaceConsistencyListener#handleModifyEvent 】. The listeners are sorted by priority in 【CatalogImpl#addListener】. Raise the priority of xx so that the cache can be cleared at the end

[sikeoka]

Could you add something in the code comments that you're changing the default priority so that NamespaceWorkspaceConsistencyListener is always run first to make it clear for anyone looking at the code in the future?

[Tian-geer]

Comments have been added for description

[NielsCharlier]

Looks good to me

[sikeoka]

Can you revert your CatalogImpl change so that this PR is only changing one file (ConfigDatabase)? The QA check is failing on your CatalogImpl change which isn't necessary for this PR. I will merge this PR after GitHub is showing only one changed file.

[Tian-geer]

Comments for catalogImpl were deleted