SLD package extension [GEOS-6837] #757

josegar74 · 2014-09-22T12:20:19Z

A extension to upload with the REST API a zip package with SLD file and related resources (images) to Geoserver.

Code to review.

https://jira.codehaus.org/browse/GEOS-6837

jdeolive · 2014-09-22T12:57:32Z

Thanks Jose. I wonder though if this could be rolled directly into the core rest interface rather than a community module?

josegar74 · 2014-09-22T12:59:36Z

Will manage tomorrow about this, updating the pull request.

simboss · 2014-09-22T13:07:49Z

Maybe also adding a few tests ;)

jdeolive · 2014-09-23T15:26:12Z

Thanks Jose. Sorry if I wasn't clear before but I was thinking we would roll this into the existing styles resource, rather than break out a new url for it. So basically just updated StyleResource to accept a zip file as input on PUT/POST.

josegar74 · 2014-09-25T06:17:12Z

Thanks for the feedback, I'll check to update StyleResource and add unit testing.

aaime · 2014-10-05T08:26:41Z

Any progress on this one?

josegar74 · 2014-10-17T07:38:39Z

Quite busy with other projects and could not manage yet to complete the work on this, hope in coming weeks can have it ready.

jodygarnett · 2014-10-28T13:32:52Z

This would be cool, let us know how it goes @josegar74

aaime · 2014-12-08T09:22:19Z

Any update? :)

jodygarnett · 2015-01-14T19:20:46Z

Without an update this won't make it into the GeoServer 2.7 release...

mbarto · 2015-01-15T17:37:05Z

I can try to review the PR and add some tests tomorrow, so that it can be merged before the freeze.

mbarto · 2015-01-16T12:24:32Z

Hi created a new pull request for this (#894) with some tests and basic documentation.
I also created a JIRA (http://jira.codehaus.org/browse/GEOS-6837) for it.

josegar74 · 2015-01-17T14:20:28Z

Hi

Apologies, as I have been busy with other stuff and could not manage about this.

I started with Justin suggestions, adding some unit testing and refactoring the code in this branch: https://github.com/josegar74/geoserver/commits/sld_package_styleresource , but requires still some checks.

Looks like @mbarto looks has done some improvements of the original code, so I guess can be fine.

aaime · 2015-01-17T14:22:46Z

See the thread on geoserver-devel, it appears that Mauro's work does not yet match Justin's original request (it still creates a new url to hit)

josegar74 · 2015-01-17T17:20:45Z

I see, I'll check next week to find some time to finish this. Apologies for delays in providing it.

jdeolive · 2015-01-17T17:34:37Z

Fwiw I don't want to have my feedback be a blocker, if there is a big push
to get it in now as is go for it.

On Saturday, January 17, 2015, josegar74 notifications@github.com wrote:

I see, I'll check next week to find some time to finish this. Apologies
for delays in providing it.

—
Reply to this email directly or view it on GitHub
#757 (comment).

aaime · 2015-01-17T20:35:08Z

Eh, at this point I believe we might be too late, Jody is going to cut 2.7-beta Monday and the feature freeze will start.

jodygarnett · 2015-01-18T03:27:13Z

I also noted the new "sld" endpoint and found it a but rough (especially as
we now support multiple styles for css). I am happy to wait until after the
code freeze and back port this REST API change when it is ready.

Jody Garnett

On 17 January 2015 at 09:34, Justin Deoliveira notifications@github.com
wrote:

Fwiw I don't want to have my feedback be a blocker, if there is a big push
to get it in now as is go for it.

On Saturday, January 17, 2015, josegar74 notifications@github.com
wrote:

I see, I'll check next week to find some time to finish this. Apologies
for delays in providing it.

—
Reply to this email directly or view it on GitHub
#757 (comment).

—
Reply to this email directly or view it on GitHub
#757 (comment).

jodygarnett · 2015-01-18T03:28:37Z

src/restconfig/src/main/java/applicationContext.xml

+        <entry>
+          <key><value>/sld/{workspace}/{style}</value></key>
+          <value>stylePackageFinder</value>
+        </entry>


I assume this is the new endpoint, can we do anything more generic (as sld is not the only thing in the mix - see StyleHandler interface).

jodygarnett · 2015-01-18T03:31:47Z

Looks like we should move conversation over to #894 and mark this request as closed?

…resource

…nd code refactor

josegar74 · 2015-01-19T14:07:20Z

Updated the code to use the the style resource url, added unit tests and documentation.

mbarto · 2015-01-19T15:08:32Z

doc/en/user/source/rest/api/styles.rst

@@ -94,7 +95,7 @@ Controls a given style.
   * - GET
     - Return style ``s``
     - 200
-     - SLD, HTML, XML, JSON
+     - SLD, HTML, XML, JSON, ZIP
     - HTML


I don't think ZIP (SLDPackage) is supported for GET: am I wrong?

The SLDPackageHandler.encode manages about this. But maybe is better to just delegate to sldHandler.encode and return the SLD raw file. What do you think?

Not sure, is the GET with application/zip content-type just zipping the sld file? We don't have the images in the file I suppose. Probably it's not worth having this if we are not creating a "package" for GET too.

For now yes, only the sld. Changed to return the SLD instead. In the future can be improved to return a full package with all related resources if that is useful.

…t and update header

mbarto · 2015-02-20T10:22:44Z

Looks good to me with latest changes.

aaime · 2015-02-20T11:24:50Z

Nice. We just need to wait the freeze to be over and then we can merge on master (GeoServer 2.8.x)

jodygarnett · 2015-02-20T18:38:31Z

I think the feature freeze is over, there is now a master and a 13.x branch
(we only have build problems with the 13.x jobs).

Jody Garnett

On 20 February 2015 at 03:24, Andrea Aime notifications@github.com wrote:

Nice. We just need to wait the freeze to be over and then we can merge on
master (GeoServer 2.8.x)

—
Reply to this email directly or view it on GitHub
#757 (comment).

aaime · 2015-02-21T08:52:47Z

You mean a 2.7.x branch: https://github.com/geoserver/geoserver/tree/2.7.x ;-)

aaime · 2015-02-22T14:27:52Z

All right, let's merge then

SLD package extension [GEOS-6837]

SLD package extension

e548668

Move SLD package extension to restconfig module

22ca4ac

Move SLD package extension in StyleResource

feed5d9

riniangreani force-pushed the master branch from a2480a8 to 20ff240 Compare October 21, 2014 06:35

aaime force-pushed the master branch from 20ff240 to 793476e Compare October 21, 2014 07:41

jodygarnett reviewed Jan 18, 2015
View reviewed changes

jodygarnett changed the title ~~SLD package extension~~ SLD package extension [GEOS-6837] Jan 19, 2015

josegar74 added 2 commits January 19, 2015 09:38

Merge remote-tracking branch 'upstream/master' into sld_package_style…

c3dd923

…resource

Move SLD package extension in StyleResource. Added docs, unit tests a…

4af2491

…nd code refactor

Delawen mentioned this pull request Jan 19, 2015

SLD package for restconfig module (zip upload of sld and related images) [GEOS-6837] #894

Closed

mbarto reviewed Jan 19, 2015
View reviewed changes

josegar74 added 2 commits January 20, 2015 09:41

Move SLD package extension in StyleResource. Removed unrequired impor…

3ef9bbc

…t and update header

Move SLD package extension in StyleResource. Removed ZIP format from GET

2ab6b14

aaime added a commit that referenced this pull request Feb 22, 2015

Merge pull request #757 from josegar74/sld_package

4f0ba02

SLD package extension [GEOS-6837]

aaime merged commit 4f0ba02 into geoserver:master Feb 22, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SLD package extension [GEOS-6837] #757

SLD package extension [GEOS-6837] #757

josegar74 commented Sep 22, 2014

jdeolive commented Sep 22, 2014

josegar74 commented Sep 22, 2014

simboss commented Sep 22, 2014

jdeolive commented Sep 23, 2014

josegar74 commented Sep 25, 2014

aaime commented Oct 5, 2014

josegar74 commented Oct 17, 2014

jodygarnett commented Oct 28, 2014

aaime commented Dec 8, 2014

jodygarnett commented Jan 14, 2015

mbarto commented Jan 15, 2015

mbarto commented Jan 16, 2015

josegar74 commented Jan 17, 2015

aaime commented Jan 17, 2015

josegar74 commented Jan 17, 2015

jdeolive commented Jan 17, 2015

aaime commented Jan 17, 2015

jodygarnett commented Jan 18, 2015

jodygarnett Jan 18, 2015

jodygarnett commented Jan 18, 2015

josegar74 commented Jan 19, 2015

mbarto Jan 19, 2015

josegar74 Jan 20, 2015

mbarto Jan 20, 2015

josegar74 Jan 20, 2015

mbarto commented Feb 20, 2015

aaime commented Feb 20, 2015

jodygarnett commented Feb 20, 2015

aaime commented Feb 21, 2015

aaime commented Feb 22, 2015

SLD package extension [GEOS-6837] #757

SLD package extension [GEOS-6837] #757

Conversation

josegar74 commented Sep 22, 2014

jdeolive commented Sep 22, 2014

josegar74 commented Sep 22, 2014

simboss commented Sep 22, 2014

jdeolive commented Sep 23, 2014

josegar74 commented Sep 25, 2014

aaime commented Oct 5, 2014

josegar74 commented Oct 17, 2014

jodygarnett commented Oct 28, 2014

aaime commented Dec 8, 2014

jodygarnett commented Jan 14, 2015

mbarto commented Jan 15, 2015

mbarto commented Jan 16, 2015

josegar74 commented Jan 17, 2015

aaime commented Jan 17, 2015

josegar74 commented Jan 17, 2015

jdeolive commented Jan 17, 2015

aaime commented Jan 17, 2015

jodygarnett commented Jan 18, 2015

jodygarnett Jan 18, 2015

Choose a reason for hiding this comment

jodygarnett commented Jan 18, 2015

josegar74 commented Jan 19, 2015

mbarto Jan 19, 2015

Choose a reason for hiding this comment

josegar74 Jan 20, 2015

Choose a reason for hiding this comment

mbarto Jan 20, 2015

Choose a reason for hiding this comment

josegar74 Jan 20, 2015

Choose a reason for hiding this comment

mbarto commented Feb 20, 2015

aaime commented Feb 20, 2015

jodygarnett commented Feb 20, 2015

aaime commented Feb 21, 2015

aaime commented Feb 22, 2015