Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to include theme 2.0 #1496

Closed
offtherailz opened this issue Feb 22, 2017 · 1 comment
Closed

Support to include theme 2.0 #1496

offtherailz opened this issue Feb 22, 2017 · 1 comment

Comments

@offtherailz
Copy link
Member

offtherailz commented Feb 22, 2017

Include and support theme 2.0.

After this step, we can imagine to allow inclusion and dynamic switching with proper loaders. see this: geosolutions-it/MapStore2-theme#99

@allyoucanmap
Copy link
Contributor

Some notes:

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/css/bootstrap.min.css">
<!--<link rel="stylesheet" href="https://rawgit.com/geosolutions-it/MapStore2-theme/master/theme/default/css/css.css">-->
<link rel="stylesheet/less" type="text/css" href="MapStore2-theme/theme/default/theme.less" />
<script src="//cdnjs.cloudflare.com/ajax/libs/less.js/2.7.2/less.min.js"></script>
<link rel="stylesheet" href="MapStore2-theme/theme/default/css/ms2-theme.css">
<link rel="stylesheet" href="MapStore2-theme/theme/default/css/icons.css">

I included the theme2.0 with the above setup with the less CDN to test the variables.less.
I noticed that if i try to change the brand color (e.g. black) it changes only in few styles (e.g. background of icons) the others are still the same color because there are color/background-color in the ms2-theme.css.
In the image are highlighted in red all the color/backgroung color in the ms2-theme.css.

eye5

Some icons have a overflow problem, in the image below the eye is clipped the reason could be because the font is outside of the borders

eye3

this is the theme2.0 eye font

eye

this is the previous eye font

eye2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants