Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading persistence of CSW advanced settings edits in dashboards #10358

Closed
1 task done
mahmoudadel54 opened this issue May 23, 2024 · 0 comments · Fixed by #10412 or #10439
Closed
1 task done

Misleading persistence of CSW advanced settings edits in dashboards #10358

mahmoudadel54 opened this issue May 23, 2024 · 0 comments · Fixed by #10412 or #10439

Comments

@mahmoudadel54
Copy link
Collaborator

mahmoudadel54 commented May 23, 2024

Description

Misleading Persistence of CSW Advanced Settings Edits in Dashboards. Edits made to CSW advanced settings in the catalog don't appear to persist after saving a new dashboard that uses the CSW service.

How to reproduce

  • Create a new dashboard
  • Try to add new map with layers from CSW and in the catalog at the default CSW and before adding the layers to the map, make some edits to the default CSW service's advanced settings.
  • Save the dashboard
  • Refresh the page and check the CSW service's advanced settings to see if the edits user made before is already existing or is gone.
01.mp4
  • Try to switch to another service in catalog like WMS and back to CSW, you will see the applied edits.
02.mp4

Expected Result
The changes made to the CSW advanced settings should be persisted after refreshing the saved the dashboard.

Current Result
After the saved dashboard refresh, the changes to the CSW advanced settings seem to disappear from the dashboard.
However, the changes are still applied and become visible again if the user switches back to the CSW service within the catalog.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

I think it is related to missing a property of 'dashboardSelectedService' in saving dashboard process.
the issue is related to this line:

isEmpty(dashboardSelectedService) ? {...defaultServices[defaultSelectedService],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment