Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make matplotlib an optional dependency #63

Closed
rth opened this issue Jun 29, 2017 · 2 comments
Closed

Make matplotlib an optional dependency #63

rth opened this issue Jun 29, 2017 · 2 comments

Comments

@rth
Copy link
Contributor

rth commented Jun 29, 2017

Currently matplotlib is a hard dependency and it is imported as import matplotlib.pyplot as plt at the top of most source files. It might be better to make it an optional dependency so that krigging would still work even if matplotlib is not installed and the plotting would fail with some explicit error message asking to install matplotlib.

This is in particularly useful when computing kriging on a remote server, where plotting might not be best suited anyway.

@bsmurphy
Copy link
Contributor

bsmurphy commented Jul 4, 2017

Agreed, do you think placing it as an import directly in the functions where it's used would be best? (I believe those would just be the user interface functions/methods, like plot_variogram and stuff like that...)

@MuellerSeb
Copy link
Member

Done with v1.5

@MuellerSeb MuellerSeb modified the milestones: v2.0, 1.5 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants