Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic WellKnownName support #18

Merged
merged 3 commits into from May 26, 2020
Merged

Basic WellKnownName support #18

merged 3 commits into from May 26, 2020

Conversation

b4l
Copy link
Contributor

@b4l b4l commented May 22, 2020 •
edited

Depends on #17 for the CI to pass

@b4l b4l requested a review from ger-benjamin May 22, 2020 10:54
ger-benjamin
ger-benjamin reviewed May 25, 2020
View reviewed changes
src/MapfileStyleParser.ts Outdated Show resolved Hide resolved
src/MapfileStyleParser.ts Outdated Show resolved Hide resolved
@b4l b4l requested a review from ger-benjamin May 25, 2020 18:34
ger-benjamin
ger-benjamin approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure my solution was working, I had no time to test.
I had tried to have a relatively generically solution. Looking for a sequence of coordinate.

But anyway, your solution works well. I've added a commit with test cases to be sure.
Please merge

@b4l b4l merged commit 0329498 into master May 26, 2020
@b4l b4l deleted the wkn branch May 26, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b4l @ger-benjamin