Uses outline and opacity defaults for polygon fill #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVolland
approved these changes
May 18, 2021
| @@ -784,16 +784,19 @@ export class QGISStyleParser implements StyleParser { | |||
| } | |||
|
|
|||
| getQmlFillSymbolFromSymbolizer(symbolizer: FillSymbolizer): any { | |||
| const fillOpacity = symbolizer.fillOpacity !== undefined ? symbolizer.fillOpacity : symbolizer.opacity; | |||
| const outlineOpacity = symbolizer.outlineOpacity !== undefined ? symbolizer.outlineOpacity : symbolizer.opacity; | |||
There was a problem hiding this comment.
Just a note:
Actually this is kind of tricky, as you can combine opacities in several symbolizers.
So opacity, fillOpacity and outlineOpacity might get combined. Its quite easy to multiply this when writing, but it's impossible when parsing it back to geostyler-style.
So i guess its ok to support only precise fillOpacity and outlineOpacity or opacity.
There was a problem hiding this comment.
Yes, I had to implement a distinction for outlineOpacitiy and fillOpacitity at this point, but to remain compatible I wanted to keep the original opacitiy value in mind if it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR
outlineOpacityandfillOpacityforFillSymbols(polygons)opacity = 0.5)@KaiVolland @jansule please review