Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes styleguidist config work on windows (refs #1726) #1736

Merged
merged 1 commit into from
Jun 9, 2022
Merged

makes styleguidist config work on windows (refs #1726) #1736

merged 1 commit into from
Jun 9, 2022

Conversation

slafayIGN
Copy link
Contributor

Description

Uses path module to make styleguidist build work in both linux and windows environments.

Related issues or pull requests

refs issue #1726

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@KaiVolland
Copy link
Collaborator

Thx.

@KaiVolland KaiVolland merged commit 3094c92 into geostyler:master Jun 9, 2022
@slafayIGN slafayIGN deleted the styleguidist-config branch June 9, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants