Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7290] Visual difference for ReprojectGoogleMercatorLargerThanWorld test on aarch64 #4151

Merged
merged 1 commit into from Jan 6, 2023

Conversation

jodygarnett
Copy link
Member

@jodygarnett jodygarnett commented Jan 5, 2023

GEOT-7290 Powered by Pull Request Badge

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@jodygarnett
Copy link
Member Author

@davidblasby looked into this in 2022 and then could not reproduce the problem later; appears to be a consequence of floating point calculations being different across different architectures (while still being in IEEE specification).

@aaime
Copy link
Member

aaime commented Jan 5, 2023

Needs to be rebased on current main, downstream build is failing as the projects now need Java 11

@mprins mprins changed the title [GEOT-7290] relax test on aarch64 due to differences in FP calcs [GEOT-7290] Visual difference for ReprojectGoogleMercatorLargerThanWorld test on aarch64 Jan 6, 2023
@mprins mprins merged commit f935879 into geotools:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants