Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose overview strategy into the layers configuration #252

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Apr 13, 2020

Overview

This PR allows to specify the overview strategy to select on the resample / reproject operations.

Checklist

  • Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

Notes

These overview strategies behave in the same (or in a similar) way GDALWarp overview strategies behave.

The following overview strategies support is added:

"auto-higher-resolution" # a default behavior 
         # tries to pick up a resolution that matches best
"base".  # always uses the layer with the best resolution for the resampling operations
"auto-n" # n is int, where n >= 0 # behaves like gdal, 
         # so if the reoslution is a bit off, it would pick up the less resolute overview for sampleing
"level-n" # n is int, where n >= 0 # n is a number of an overview we'd like to use 
          # for all layer sampling operations

Add the overview startegy definition into the ogcExamples project application.conf:

us-ned-hillshade = {
  type = "mapalgebrasourceconf"
  name = "us-ned-hillshade"
  title = "US NED Hillshade"
  resample-method = "bilinear"
  overview-strategy = "auto-0"
...

The default behaviour is

Addresses #215

@pomadchin pomadchin changed the title Expose overview strategy into Layers configuration Expose overview strategy into layers configuration Apr 13, 2020
@pomadchin pomadchin changed the title Expose overview strategy into layers configuration Expose overview strategy into the layers configuration Apr 13, 2020
Copy link
Contributor

@CloudNiner CloudNiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending verification from client that switching strategies solves their issue!

@pomadchin
Copy link
Member Author

@CloudNiner I need this PR to be merged in for the pointcloud tests (so the snapshot of gt server would be published), I think I'll merge it in without closing the related issues.

@CloudNiner
Copy link
Contributor

👍 makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants