Receive GPG key while publishing artifacts #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colekettler
commented
Jun 5, 2020
Comment on lines
-29
to
-30
| gpg --batch \ | ||
| --passphrase "${GPG_PASSPHRASE}" \ |
There was a problem hiding this comment.
Because we're not using passphrase for this key, the --batch and --passphrase options are unnecessary.
rbreslow
reviewed
Jun 5, 2020
| @@ -25,10 +25,10 @@ aliases: | |||
| - run: | |||
| name: "Import signing key" | |||
| command: | | |||
| gpg --keyserver keyserver.ubuntu.com \ | |||
There was a problem hiding this comment.
It's worth surfacing that we're specifying the Ubuntu keyserver here to mirror the approach taken by @jodersky. Through testing, I've found that this keyserver was updated more quickly than the default.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This retrieves an up-to-date copy of the Geotrellis public GPG key during the
cipublishbuild stage.We've pushed a new signature to extend the expiration date on the public key that we've uploaded to public keyservers. The CircleCI build will now retrieve the latest copy of the public key, allowing us to renew the key in the future using the same procedure.
Checklist
Testing Instructions
cipublish.Connects azavea/operations#446