-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose STAC temporal metadata #279
Expose STAC temporal metadata #279
Conversation
4b50020
to
1bf635d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple clarifying questions before a more thorough review to help me understand the changes made here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a really compelling reason otherwise, we should exhaustive match our ADTs. Also should fix up the regression in parsing params noted previously.
I'm willing to let the ADT change go through, but I think it's a bad idea, see comment for a few potential alternative solutions.
ogc/src/main/scala/geotrellis/server/ogc/OgcSourceRepository.scala
Outdated
Show resolved
Hide resolved
@CloudNiner the current OgcTime tree is the following: sealed trait OgcTime
case object OgcTimeEmpty extends OgcTime
final case class OgcTimePositions(list: NonEmptyList[ZonedDateTime]) extends OgcTime
final case class OgcTimeInterval(start: ZonedDateTime, end: Option[ZonedDateTime], interval: Option[String]) extends OgcTime And you think using
|
I'll work on the interfaces a bit more, but I think that |
As an alternative we can have a |
We chatted a bit about this after standup, adding some notes here. I like the idea of making OgcTimeInterval explicitly an interval and seeing how that falls out, which would make end required in the case class, not sure if |
65f89a0
to
35e8655
Compare
35e8655
to
b18933e
Compare
b1f1295
to
016a212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the couple remaining minor issues are addressed and the build is green.
|
||
/** | ||
* TODO: replace with source.extentIn(LatLng) | ||
* see: https://github.com/locationtech/geotrellis/issues/3258 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
stac-example/src/main/scala/geotrellis/stac/raster/StacAssetRasterSource.scala
Outdated
Show resolved
Hide resolved
bd0a9b2
to
3932b75
Compare
3932b75
to
225bac5
Compare
Overview
This PR adds exposes stac temporal extent thought the temporal metadata (and covers #259 at the same time):
It also fixes #260:
Checklist
Closes #259
Closes #260
Closes https://github.com/azavea/geotrellis/issues/278