Refactor not to bind effect type #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
changed the title
3 tasks
pomadchin
force-pushed
the
feature/refactor-tagless-final-etc
branch
4 times, most recently
from
4cedfd0
to
5f14a73
Compare
CloudNiner
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
So much to look at here. I only took a cursory glance.
Changes do look good overall though, thrilled to see the removal of Scala 2.11, removal of subproject, and use of consistent scalafmt settings.
Merge whenever you feel confident, we'll have to address smaller fall out as separate future issues anyway.
|
Blocked by locationtech/geotrellis#3265 |
repository -> RepositoryM MapAlgebraStacOgcRepositories StacOgcRepositories all of it it's a heartbreaking work of staggering genius
pomadchin
force-pushed
the
feature/refactor-tagless-final-etc
branch
from
865c877
to
03658ff
Compare
1 task
This was referenced Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes it so that gt-server doesn't commit downstream consumers to
IOeverywhere, instead leaving everything inF[_]untilFgains some constraints by usage.Checklist
Testing Instructions
IOeverywhereCloses azavea/azavea-10-percent-time#320
Closes #257
Closes https://github.com/azavea/geotrellis/issues/268