Reject requests with unsupported versions #313
Merged
+40
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the version param validation logic to take a param of which versions are supported. As the validation logic was written before, it was happy to take any string as the
version
param, which led unexpected successes for versions that don't matchwhat the server is actually capable of.
Checklist
Demo
Testing Instructions
GetCapabilities
requests as above for wcs, wms, and wmts services using supported versions (1.1.1, 1.3.0, and 1.0.0, respectively)acceptedVersions
set to a comma-separated list that includes the valid version -- this should workacceptedVersions
set to a comma-separated list that excludes the valid version -- this should give you a 400Closes #307