Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build errors and show notifications #16

Merged
merged 1 commit into from
Aug 28, 2016
Merged

Conversation

geowarin
Copy link
Owner

@geowarin geowarin commented Aug 7, 2016

This is heavily inspired by the work of @gaearon on create-react-app.

There is an option to disable the OS notifications in the tarec.yml configuration file:

build:
  # show notifications on build failure. Default, true
  showNotification: true

Result:

Build error notifications

@geowarin geowarin force-pushed the notifications branch 2 times, most recently from 45884d1 to ec6ce7f Compare August 7, 2016 11:50
return error;
}

function extractError (e) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything here that you would like to contribute back? 😄

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon Totally! I was thinking about extracting a module for this plugin.
It still needs a bit of work and some tests.
I'll make a PR when it's ready 😄

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 93.261% when pulling d069323 on notifications into 66287ec on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants