Update button selector #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail because today is the 22nd. Entering a 22 into the day field of the website actually enters 21, because 2 is taken as 20 and every succeeding 2 just increases the day by 1. Same goes for 0, 1 and 3, which means there is a bigger underlying issue to fix first. Btw: You can also get timetables for the 31st of February from within the UI and the CLI. |
gerardcl
force-pushed
the
fix/button-selector
branch
from
189613d
to
d475856
Compare
gerardcl
force-pushed
the
fix/button-selector
branch
from
d475856
to
4bed351
Compare
henninggross
force-pushed
the
fix/button-selector
branch
from
91b5011
to
40e5ef3
Compare
henninggross
changed the title
gerardcl
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #187