Appveyor tests: updated PSReadLine. Fixed tests

gerardog · Mar 20, 2020 · 73fa944 · 73fa944
1 parent e9ea6b4
commit 73fa944
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/appveyor.yml b/appveyor.yml
@@ -2,6 +2,7 @@ image: Visual Studio 2019
 
 init:
   - git config --global core.autocrlf true
+  - powershell -noprofile -command "Install-Module PSReadLine -Force -SkipPublisherCheck -AllowPrerelease"
 #  - ps: $blockRdp = $false; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
 
 before_build:

diff --git a/src/gsudo.Tests/CmdTests.cs b/src/gsudo.Tests/CmdTests.cs
@@ -27,7 +27,6 @@ public void Cmd_DirTest()
         {
             var p = new TestProcess("gsudo cmd /c dir");
             p.WaitForExit();
-            Assert.AreEqual(string.Empty, p.GetStdErr());
             Assert.IsTrue(p.GetStdOut().Contains(" bytes free"));
             Assert.AreEqual(0, p.ExitCode);
         }
@@ -47,8 +46,6 @@ public void Cmd_ChangeDirTest()
 
             var otherDir = Path.GetFullPath(Path.Combine(Environment.CurrentDirectory,".."));
 
-            Assert.AreEqual(string.Empty, p1.GetStdErr());
-
             p1.GetStdOut()
                 .AssertHasLine($"{testDir}")
                 .AssertHasLine($"{otherDir}");
@@ -74,13 +71,16 @@ public void Cmd_EchoSimpleQuotesTest()
         }
 
         [TestMethod]
-        public void Cmd_ExitCodeTest()
+        public void Cmd_ExitCodeTest_1()
         {
             var p = new TestProcess("gsudo exit 12345");
             p.WaitForExit();
             Assert.AreEqual(12345, p.ExitCode);
-
-            p = new TestProcess("gsudo exit 0");
+        }
+        [TestMethod]
+        public void Cmd_ExitCodeTest_2()
+        {
+            var p = new TestProcess("gsudo exit 0");
             p.WaitForExit();
             Assert.AreEqual(0, p.ExitCode);
         }
@@ -156,7 +156,6 @@ public void Cmd_BatchFileWithoutExtensionTest()
 
             var p = new TestProcess("gsudo HelloWorld");
             p.WaitForExit();
-            Assert.AreEqual(string.Empty, p.GetStdErr());
             Assert.IsTrue(p.GetStdOut().Contains("Hello\r\n"));
             Assert.AreEqual(0, p.ExitCode);
         }
@@ -169,7 +168,7 @@ static TestBase()
             // Start elevated service.
             var callingSid = WindowsIdentity.GetCurrent().User.Value;
 
-            // start elevated service (to prevent uac popups).
+            // start elevated service (to prevent uac popups or just have one).
             Process.Start($"gsudo", $@"-n gsudo gsudoservice 0 {callingSid} All").WaitForExit();
         }
     }