Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlanSubscription::active() returns true on canceled subscriptions #4

Closed
Konafets opened this issue Apr 18, 2017 · 1 comment
Closed

PlanSubscription::active() returns true on canceled subscriptions #4

Konafets opened this issue Apr 18, 2017 · 1 comment

Comments

@Konafets
Copy link
Contributor

Konafets commented Apr 18, 2017 •
edited
Loading

Mainly because the method does not check $this->canceled().

Is this intended behavior?
@Konafets
Copy link
Contributor Author

Ah, my fault. A canceled subscription can of course be active till the end of the interval.

@Yahav Yahav mentioned this issue Sep 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Konafets