New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Carboon usage #52

Merged

gerardojbaez merged 2 commits into gerardojbaez:master from adibnaya:master

Sep 27, 2019

Contributor

adibnaya commented Sep 24, 2019

return Carbon::now()->gt($this->valid_until) or Carbon::now()->eq($this->valid_until);

Carbon has gte function, Why not use it?

adibnaya added 2 commits

September 24, 2019 12:17


          Update PlanSubscription.php isEnded function

95a706c

Change return logic to use Carbon gte instead of checking once for gt and second for eq


          Update PlanSubscriptionUsage isExpired function

cf4c24c

Change return logic to use Carbon gte instead of checking once for gt and second for eq

gerardojbaez merged commit a8897b8 into gerardojbaez:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment