Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array string macro not working for short array syntax #6

Closed
gerardroche opened this issue Feb 11, 2015 · 0 comments
Closed

Array string macro not working for short array syntax #6

gerardroche opened this issue Feb 11, 2015 · 0 comments
Labels
bug indentation macro syntax
Milestone
1.0.0

Comments

@gerardroche
Copy link
Owner

Append comma newline macro not working in short array syntax string.

Re: #1 (comment)

[
    'x|'
]

Actual

[
    'x
|'
]

Expect

[
    'x',
    |
]
@gerardroche gerardroche added this to the 1.0.0 milestone Feb 11, 2015
@gerardroche gerardroche changed the title Array string macro append ,\n not working for short array syntax Array string macro not working for short array syntax Feb 11, 2015
@gerardroche gerardroche mentioned this issue Feb 11, 2015
Closed
gerardroche added a commit that referenced this issue Feb 11, 2015
@gerardroche
Merge branch 'issue6-array-string-macro' into develop
43b236d 
* issue6-array-string-macro:
  🐛 fix #6 short array syntax scope
gerardroche added a commit that referenced this issue Feb 11, 2015
@gerardroche
📝 changelog short array syntax fix #6
4145965
gerardroche added a commit that referenced this issue May 27, 2015
@gerardroche
Merge branch 'release/0.6.0'
f359602 
* release/0.6.0:
  Prepare release; Bump version and update changelog
  📝 readme
  Fix PHPDoc not matching arbitrary annotations
  Refactor testing dev tools
  📝 README; macros
  New macro <kbd>Ctrl</kbd>+<kbd>;</kbd> Append semicolon
  Fix append semicolon newline should work with PHP 5.4 array syntax
  Rename some macro files with more descriptive names
  DevTools: trim copy and print scope name newlines
  DevTools: Print scope in console
  📝 changelog
  Use meta.array.empty.php selector to target empty arrays for macros
  Add short array syntax empty array scope
  📝 changelog short array syntax fix #6
  🐛 fix #6 short array syntax scope
  Allow blank lines in test assertions
  Fix TestView should not auto indent by default
  💄
  Improve copy scope to clipboard
  Assertion failure now provides more information
  Fix method name typo
  📝 changelog
  Implement indentation test and expectation in a single file
  Implement language test suite. Closes #2
  Refactor indentation tests runner command
  Change run indentation tests keymap to ctrl+k, ctrl+i
  Completion rules: Minimise auto-complete noise
  Add macro: append ; on <Ctrl>+<Enter>
  Add macro: append ,\n in array strings on <Enter>
  Limit macros to php scope
  Add "Add line in braces" macro file from default package
  Only enable testing keymaps in development mode
  💄 keymaps
  Rename php-grammar -> plugin.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug indentation macro syntax
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@gerardroche