Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto detect color scheme #4

Closed
gerardroche opened this issue Aug 22, 2016 · 1 comment
Closed

Auto detect color scheme #4

gerardroche opened this issue Aug 22, 2016 · 1 comment

Comments

@gerardroche
Copy link
Owner

gerardroche commented Aug 22, 2016

The package name can be discovered via a test file.

For example, the package name in path/to/Packages/Theme - Cobalt2/test/color_scheme_test.css is "Theme - Cobalt2".

From here we can discover all theme files located inside the package "Theme - Cobalt2" directory.

So, given the following test:

path/to/Packages/Theme - Cobalt2/test/color_scheme_test.css

Either the header can specify the color test parameters:

/* COLOR TEST "Packages/Theme - Cobalt2/cobalt2.tmTheme" "CSS" */

Or contain no header at all. Because the parameters above can all be inferred from the test file location as described above.

@gerardroche gerardroche added this to the 1.0.0 milestone Aug 22, 2016
@gerardroche gerardroche changed the title Auto detect color scheme to test against Auto detect color scheme Sep 26, 2016
@gerardroche gerardroche removed this from the 1.0.0 milestone Jun 15, 2017
@gerardroche
Copy link
Owner Author

Auto detecting the color scheme is not a useful or as straight forward as it might seem. The definition required at the head of the test case is not really that hard so auto detecting doesn't really add much value so I'm closing. It can be reopened if this is really a very much desired or needed feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant