double "/" cause http server to fail

[bol-van]

curl http://192.168.2.7:49152/description.xml

<URLBase>http://192.168.2.7:49152/</URLBase>

Then SAMSUNG TV queries

http://192.168.2.7:49152//cm.xml

get 400 Bad request
and all futher queries come with double /

[bol-van]

Http servers should ignore multiple ////
test on any http server and it will work with any number of / in any part

[bol-van]

its not gerbera issue, but libupnp

this allows samsung tv to browse folder :

		if (membuffer_append_str(&url_str, "http://") != 0 ||
		    membuffer_append_str(&url_str, ip_str) != 0 ||
/*		    membuffer_append_str(&url_str, "/") != 0 || */
		    membuffer_append_str(&root_path, "/") != 0) {
			goto error_handler;
		}

[whyman]

Hi @bol-van, thanks for reporting.

Can you report this upstream with https://github.com/mrjimenez/pupnp?

Thanks!

[TimelessNL]

Any progress on this?
This is probably why my 2012 TVs in #352 are not working I suppose.
MediaTomb seems to had a workaround in place as well. To remove excessive slashes:

+
+        //remove excessive leading slashes (fix for Samsung Smart TV 2012)
+        while( ( ( begin_path + 1 ) < max ) && ( in[begin_path] == '/' ) && ( in[begin_path + 1] == '/') ) {
+            begin_path++;
+        }
+

[pamapa]

is this still an issue with the latest master version of gerbera?

[TimelessNL]

I've tested Gerbera v1.4.0 and libupnp v1.8.6 and that needed the fix. I could test master is there any reason to believe that it has been sorted?

[pamapa]

I have landed a fix (pupnp/pupnp@dc2c54b) to address this issue within libupnp, should be part of the next release (v1.12.2).

[pamapa]

fixed in pupnp when using a recent release: 1.12.1 or higher