Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #36

Closed
juliandavidmr opened this issue Apr 21, 2018 · 3 comments
Closed

Update readme #36

juliandavidmr opened this issue Apr 21, 2018 · 3 comments

Comments

@juliandavidmr
Copy link

Regarding the documentation of this fork. I think the installation command shown in the README should be changed, as npm install jison -g appears but should be npm install jison-gho -g.
I have seen that this fork contains many improvements over the original project, but I am convinced that this fork is the one that everyone should install.

I created this issue because at first I didn't know how to install this fork, so I took some time to find out what the installation command was. He always installed the original because it was the one that appeared in the documentation of this fork.

Thanks.

@GerHobbelt
Copy link
Owner

Good catch! 👍

@GerHobbelt
Copy link
Owner

fixed in commit SHA-1: 9bb9f97

@GerHobbelt GerHobbelt reopened this May 6, 2018
@GerHobbelt
Copy link
Owner

Should be visible now (as github shows master branch) while this is effective in the npm archive once 0.6.5 comes out.

GerHobbelt added a commit that referenced this issue Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants