credentials for services migrated to iam #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var instance = services[service_name][i]; | ||
| var usingResourceName = instance.credentials && instance.credentials.resource_name; | ||
| if ((usingResourceName && instance.credentials.resource_name === name) && | ||
| (!iname || iname === instance.name) |
There was a problem hiding this comment.
Why don't you check
if (instance.credentials.resource_name === name && (!iname || iname === instance.name)) {
// ...
}There was a problem hiding this comment.
I was just trying to be safe. In the case that credentials isn't a key on the object, that would cause the module to crash. But I can make that change
|
@dpopp07 This looks good.
|
|
Closing this PR, as |
|
Thanks for the work @dpopp07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@germanattanasio I spoke to Taj the other day about this issue. I just took a quick pass at it while I had a free minute. We may not be able to rely on the
resource_nameincredentialsso this may not be ideal, but it seemed to be that was the best way to support the migration. Let me know what you think.