Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make semantic-release a devDependency #25

Merged
merged 1 commit into from Apr 17, 2019
Merged

Make semantic-release a devDependency #25

merged 1 commit into from Apr 17, 2019

Conversation

MasterOdin
Copy link
Contributor

Currently, semantic-release is marked as a dependency (see https://www.npmjs.com/package/vcap_services) as it's installed (and subsequently saved in package.json) as part of the travis.yml build:

- npm install semantic-release@13.1.1

This sets it as a proper devDependency so that downstream modules that depend on this won't also drag in semantic-release as part of this module.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.576% when pulling fcc6009 on MasterOdin:master into a7c2087 on germanattanasio:master.

@germanattanasio germanattanasio merged commit f280da4 into germanattanasio:master Apr 17, 2019
@germanattanasio
Copy link
Owner

Thanks @MasterOdin and sorry for the troubles!

@germanattanasio
Copy link
Owner

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants