Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a feature flag to build for iOS #16

Closed
seivan opened this issue Aug 12, 2019 · 3 comments
Closed

Allow a feature flag to build for iOS #16

seivan opened this issue Aug 12, 2019 · 3 comments

Comments

@seivan
Copy link

seivan commented Aug 12, 2019

It would be necessary to set some defines (which ones I'm not sure of yet) to get this to build (and by proxy Rodio) for iOS.

https://github.com/lieff/minimp3/blob/eaa7e4d3f7ae790c02ffe88442cf333c6b5ffe58/player/stb_image.h#L213
@seivan
Copy link
Author

seivan commented Aug 12, 2019

Related RustAudio/rodio#194

@seivan
Copy link
Author

seivan commented Aug 12, 2019

Nevermind, it seems fixed now.

@seivan seivan closed this as completed Aug 12, 2019
@germangb
Copy link
Owner

Still it may be worth defining feature flags to mirror some if not all of the #defines. or perhaps using env variables with names such as MINIMP3_<define_name>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seivan @germangb