Playback clipping.

[GlenCFL]

Making this issue here at the request of @germangb within the issue found here:
RustAudio/rodio#212

MP3 playback of the simple rodio MP3 example seems to be clipping something like a second of audio from the end of the audio stream. This is particularly apparent on short audio clips, with a 1 second duration MP3 not outputting any sound and a 2 second duration MP3 cutting out midway through playback.

This is on Windows 10 x64 compiling using Rust 1.30.1 with the MSVC toolchain.

[germangb]

Hi, thanks for reporting this,

I think we missed an edge case here:

minimp3-rs/src/lib.rs

Lines 75 to 80 in 8459d48

	// Keep our buffers full
	if self.buffer.len() < REFILL_TRIGGER {
	if self.refill()? == 0 {
	return Err(Error::Eof);
	}
	}

If the last audio frame is within the first REFILL_TRIGGER bytes of the buffer, we skip it. I'll publish a new version with a patch

[germangb]

I've pushed the patch 0.3.2 to creates-io. Can you patch rodio to point to it and see if it fixes your issue?

[GlenCFL]

Sure. Give me a bit and I'll report back.

[GlenCFL]

The two sounds do work correctly now. Thanks for taking the time out of your day to fix this.

[germangb]

Not a problem 🐱 I'll update <RustAudio/rodio#213> with a version bump