Fix is_highest logic on resyncs

fixes: pulp#1547
gerrod3 · Aug 7, 2023 · f238686 · f238686
1 parent ae4598e
commit f238686
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES/1547.bugfix b/CHANGES/1547.bugfix
@@ -0,0 +1 @@
+Fixed a sporadic sync error when re-syncing a repository with new collection versions.
diff --git a/pulp_ansible/app/tasks/collections.py b/pulp_ansible/app/tasks/collections.py
@@ -461,6 +461,11 @@ def is_new_highest(new, old):
 
     # exit if the new CV is not higher
     if not is_new_highest(Version(collection_version.version), Version(last_highest.version)):
+        # Ensure that this collection_version doesn't have is_highest improperly set
+        if collection_version.is_highest:
+            collection_version.is_highest = False
+            if save:
+                collection_version.save(update_fields=["is_highest"])
         return
 
     last_highest.is_highest = False