Look at TTL when comparing rrsets.

gerrowadat · Nov 5, 2023 · 917aa45 · 917aa45
1 parent fa1c3b6
commit 917aa45
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/clouddns.go b/clouddns.go
@@ -92,7 +92,8 @@ func dumpZonefile(dnsSpec *CloudDNSSpec) {
 
 func rrsetsEqual(x *dns.ResourceRecordSet, y *dns.ResourceRecordSet) bool {
 	if x.Type != y.Type ||
-		x.Name != y.Name {
+		x.Name != y.Name ||
+		x.Ttl != y.Ttl {
 		return false
 	}
 

diff --git a/clouddns_test.go b/clouddns_test.go
@@ -52,6 +52,21 @@ func Test_rrsetsEqual(t *testing.T) {
 			},
 			want: false,
 		},
+		{
+			name: "DifferingTtl",
+			args: args{
+				x: &dns.ResourceRecordSet{
+					Type: "A",
+					Name: "hostname.example.com",
+					Ttl:  60,
+				},
+				y: &dns.ResourceRecordSet{
+					Type: "A",
+					Name: "hostname.example.com",
+				},
+			},
+			want: false,
+		},
 		{
 			name: "DifferingRRdatas_len",
 			args: args{