Feature/gui convert #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SourceSansPro font files. Added logo and cover images.
Added a new constructor for the CM swing components that incorporate position and size settings, so we can save some unnecessary code lines in the GUI assembler functions. Added new CM variations for the Swing components: JSpinner and JComboBox. Added seperate ToolchainExecutors for each step of the process. Improved handling of the intermediate files, and stored them in separate folders for each execution. Improved the handling and validation of the ExecutionOptions.
Replaced the duplicated image and added two more. Also resized all of them so they won't look as stretched.
…ic option validation has failed.
Also corrected the exception handling, so when an error occurs during toolchain execution, we can notify the user that the generation has failed.
Moved hard-coded labels to a translation file. Corrected some formatting mistakes.
…the code more readable.
… bug in the eclipse autoformatter.
|
Thank you for your fast reaction and your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
According to your comment on our last pull request, we have added a dialog window displaying the output of the toolchain execution.
We have pulled the latest changes (as of 1st May), from the original repository's develop branch, and merged it with our contribution. Luckily there were no conflicts, we only needed to change the version numbers in our pom.xml. Due to the way we implemented the layout selector, the temporary removal of the TETRIS layout enum also automatically removed it from the selector's list.
We also have refactored some parts:
We tried to keep a consistent coding style as similar as we could to the original code. We hope that you're going to find it clean and readable as well!
Looking forward for your reply,
Adam Bankeszi