Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support PSL #14

Closed
schochastics opened this issue Sep 22, 2023 · 1 comment
Closed

support PSL #14

schochastics opened this issue Sep 22, 2023 · 1 comment
Assignees
@schochastics
Labels
0.2.0

Comments

@schochastics
Copy link
Member

schochastics commented Sep 22, 2023 •
edited

The main purpose of the package is to wrap ada-url. But their might be other features we could support (which are needed for webtrackR).

One such feature is public suffix extraction via PSL. There is a package for that but it is not on CRAN.

The list is accessible as a textfile here and here.

We may not be able to implement something fast, but a simple lookup-ish thing should be possible
@schochastics schochastics self-assigned this Sep 23, 2023
schochastics added a commit that referenced this issue Sep 24, 2023
@schochastics
Merge pull request #17 from schochastics/psl
2ef77ef 
add support for public suffix extraction #14
@schochastics
Copy link
Member Author

Needs more tests once #18 is dealt with

@schochastics schochastics mentioned this issue Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schochastics schochastics

Labels
0.2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schochastics