Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ada_get_domain() doesnt work if path present #51

Closed
schochastics opened this issue Sep 28, 2023 · 0 comments
Closed

ada_get_domain() doesnt work if path present #51

schochastics opened this issue Sep 28, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@schochastics
Copy link
Member

schochastics commented Sep 28, 2023

adaR::ada_get_domain("http://sub.google.de/test")
#> [1] NA

This is due to public_suffix() not being able to parse URLs with paths

adaR::public_suffix("http://google.de/test")
#> [1] NA
psl::public_suffix("http://google.de/test")
#> [1] "de/test"

Not sure if this should be NA instead of de. But then again, psl also fails.
For now, we fix ada_get_domain internally and reconsider public_suffix in #54

@schochastics schochastics added the bug Something isn't working label Sep 28, 2023
@schochastics schochastics self-assigned this Sep 28, 2023
schochastics added a commit that referenced this issue Sep 28, 2023
@schochastics schochastics changed the title public_suffix doesnt work if path present ada_get_domain() doesnt work if path present Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant