Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnRipley the package #149

Closed
chainsawriot opened this issue Jul 27, 2023 · 3 comments · Fixed by #153
Closed

UnRipley the package #149

chainsawriot opened this issue Jul 27, 2023 · 3 comments · Fixed by #153

Comments

@chainsawriot
Copy link
Collaborator

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_rang.html.

Please correct before 2023-08-11 to safely retain your package on CRAN.

The CRAN Team
@chainsawriot
Copy link
Collaborator Author

The cause is that this test is not wrapped with skip_on_cran()

https://github.com/chainsawriot/rang/blob/3c236aff92a9ec097c7b0441b8877af990198f3f/tests/testthat/test_resolve.R#L148-L153

It can be easily plugged.

But the other problem is that resolve() is surprisingly nondeterministic in the test environment.

@chainsawriot chainsawriot mentioned this issue Jul 30, 2023
Closed
chainsawriot added a commit that referenced this issue Jul 30, 2023
@chainsawriot
Fix #150 fix #149
1bdb2b6
@chainsawriot chainsawriot mentioned this issue Jul 30, 2023
Closed
chainsawriot added a commit that referenced this issue Jul 30, 2023
@chainsawriot
Fix #150 fix #149 fix#152 (#151)
eb76625 
* Fix #150 fix #149

* Retry when hit by r-hub/pkgsearch#117

To make resolve more determinstic
@chainsawriot chainsawriot mentioned this issue Jul 30, 2023
Merged
chainsawriot added a commit that referenced this issue Jul 30, 2023
@chainsawriot
Merge pull request #153 from chainsawriot/v0.2
91f1b9f 
Backport from v0.2

Fix #150 fix #149 fix#152 (#151)
@chainsawriot chainsawriot reopened this Jul 30, 2023
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Jul 30, 2023 •
edited
Loading

TODO

  • Release 169f1be to CRAN after their Sommerpause.

@chainsawriot
Copy link
Collaborator Author

52fe7d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #150 fix #149 fix#152 (#151) gesistsa/rang
1 participant
@chainsawriot