Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving openxlsx to Imports #150

Closed
pkq opened this issue Apr 27, 2017 · 2 comments
Closed

Consider moving openxlsx to Imports #150

pkq opened this issue Apr 27, 2017 · 2 comments

Comments

@pkq
Copy link
Contributor

pkq commented Apr 27, 2017

Currently, .xlsx is the only format for which import() works on a fresh install of rio but export() does not. For all other formats where both functions are supported, you can either do both without running install_formats() (e.g., .csv), or neither (e.g., .csvy). For consistency, does it make sense to move openxlsx to Imports?

@leeper
Copy link
Contributor

leeper commented Apr 27, 2017

Yes, probably a good idea. No need for a PR. I'll make a decision on this before next CRAN release.

@pkq
Copy link
Contributor Author

pkq commented Apr 27, 2017

Sounds good, thanks. Do you have a sense yet for when that might be? Just realized that, at the moment, the directions to run install_formats only apply to the development version, which may be confusing. I'd be happy to help clarify, but may not be worth it if this version is going to CRAN soon.

@leeper leeper modified the milestone: v0.5 Apr 28, 2017
@leeper leeper closed this as completed in 1f0e53c Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants