Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making .import.rio_xls() follow the same format at .import.rio_xlsx() #224

Closed
1 of 3 tasks
bokov opened this issue Sep 19, 2019 · 0 comments
Closed
1 of 3 tasks

Making .import.rio_xls() follow the same format at .import.rio_xlsx() #224

bokov opened this issue Sep 19, 2019 · 0 comments
Milestone

Comments

@bokov
Copy link
Contributor

bokov commented Sep 19, 2019

Please specify whether your issue is about:

  • a possible bug
  • a question about package functionality
  • a suggested code or documentation change, improvement to the code, or feature request

Minor tweak.

readxl::read_xls() and readxl::read_xlsx() have identical call signatures:

all.equal(args(readxl::read_xlsx),args(readxl::read_xlsx))

# [1] TRUE

Yet .import.rio_xls() is completely different from .import.rio_xlsx(). If the answer to #223 is affirmative, while I'm in there anyway, I could revise .import.rio_xls() to follow the same pattern as .import.rio_xls().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants